SDK-91: Java sdk: JsonParseException: Numeric value (2393972736.0) ou… #62
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t of range of int (-2147483648 - 2147483647)
| @@ -20,8 +20,8 @@ | |||
| @JsonIgnoreProperties(ignoreUnknown = true) | |||
| public class Query | |||
| { | |||
| private int id; | |||
There was a problem hiding this comment.
Why change the id to be an int?
We are < 20 million right now, It would be a really long time before we hit 2 billion.
There was a problem hiding this comment.
no specific reason, thought it is better to move the ints to long to avoid such issues in future.
dont think this will effect the functionality.
rohitagarwal003
pushed a commit
to rohitagarwal003/qds-sdk-java
that referenced
this pull request
Feb 8, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Java sdk: JsonParseException: Numeric value (2393972736.0) out of range of int (-2147483648 - 2147483647)