make zstd optional in sstable #2633
Conversation
|
I would prefer a separate feature flag |
|
@PSeitz Do you mean Also do you want I'll fix the |
|
I think I see what you wanted so I pushed a commit. Happy to iterate if that's not exactly right just lmk. Also pushed a |
Yes, for a tantivy user the sstable is more like an implementation detail, unlike the columnar storage. |
CHANGELOG.md
Outdated
| @@ -2,6 +2,9 @@ Tantivy 0.23 - Unreleased | |||
| ================================ | |||
| Tantivy 0.23 will be backwards compatible with indices created with v0.22 and v0.21. The new minimum rust version will be 1.75. | |||
|
|
|||
| > [!WARNING] | |||
There was a problem hiding this comment.
that's already outdated with the last release
https://github.com/quickwit-oss/tantivy/pull/2621/files
There was a problem hiding this comment.
I'm not sure I understand: I didn't update the lines linked in that pr so even if we do 0.24 I'm not sure I see the problem.
I could rebase but I don't think that's what you mean because that pr isn't merged.
There was a problem hiding this comment.
0.24 is already released, but the CHANGELOG pr is not yet merged
| [features] | ||
| unstable = [] | ||
| zstd-compression = ["sstable/zstd-compression"] |
There was a problem hiding this comment.
that should be a default feature flag
There was a problem hiding this comment.
Are you saying I should make it a default flag and then eliminate the changelog entry so we can merge this PR?
|
@trinity-1686a / @PSeitz lmk if there's anything else I can do to bring this closer to being merged and ultimately released |
sstable. See more info here: