Skip to content

Push on main

Push on main #52

GitHub Actions / clippy succeeded Apr 9, 2025 in 0s

clippy

9 warnings

Details

Results

Message level Amount
Internal compiler error 0
Error 0
Warning 9
Note 0
Help 0

Versions

  • rustc 1.86.0 (05f9846f8 2025-03-31)
  • cargo 1.86.0 (adf9b6ad1 2025-02-28)
  • clippy 0.1.86 (05f9846f89 2025-03-31)

Annotations

Check warning on line 247 in columnar/src/columnar/writer/column_operation.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

manually reimplementing `div_ceil`

warning: manually reimplementing `div_ceil`
   --> columnar/src/columnar/writer/column_operation.rs:247:5
    |
247 |     (msb + 7) / 8
    |     ^^^^^^^^^^^^^ help: consider using `.div_ceil()`: `msb.div_ceil(8)`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_div_ceil

Check warning on line 120 in columnar/src/column_values/u64_based/linear.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

manually reimplementing `div_ceil`

warning: manually reimplementing `div_ceil`
   --> columnar/src/column_values/u64_based/linear.rs:120:19
    |
120 |                 + (num_bits as u64 * stats.num_rows as u64 + 7) / 8,
    |                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.div_ceil()`: `(num_bits as u64 * stats.num_rows as u64).div_ceil(8)`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_div_ceil

Check warning on line 112 in columnar/src/column_values/u64_based/bitpacked.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

manually reimplementing `div_ceil`

warning: manually reimplementing `div_ceil`
   --> columnar/src/column_values/u64_based/bitpacked.rs:112:34
    |
112 |         Some(stats.num_bytes() + (stats.num_rows as u64 * (num_bits_per_value as u64) + 7) / 8)
    |                                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.div_ceil()`: `(stats.num_rows as u64 * (num_bits_per_value as u64)).div_ceil(8)`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_div_ceil
    = note: `#[warn(clippy::manual_div_ceil)]` on by default

Check warning on line 110 in columnar/src/column_index/merge/stacked.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this `repeat().take()` can be written more concisely

warning: this `repeat().take()` can be written more concisely
   --> columnar/src/column_index/merge/stacked.rs:110:22
    |
110 |             Box::new(std::iter::repeat(1u32).take(optional_index.num_non_nulls() as usize))
    |                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `repeat_n()` instead: `std::iter::repeat_n(1u32, optional_index.num_non_nulls() as usize)`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_repeat_n

Check warning on line 108 in columnar/src/column_index/merge/stacked.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this `repeat().take()` can be written more concisely

warning: this `repeat().take()` can be written more concisely
   --> columnar/src/column_index/merge/stacked.rs:108:39
    |
108 |         ColumnIndex::Full => Box::new(std::iter::repeat(1u32).take(num_docs as usize)),
    |                                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `repeat_n()` instead: `std::iter::repeat_n(1u32, num_docs as usize)`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_repeat_n
    = note: `#[warn(clippy::manual_repeat_n)]` on by default

Check warning on line 441 in sstable/src/sstable_index_v3.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

manually reimplementing `div_ceil`

warning: manually reimplementing `div_ceil`
   --> sstable/src/sstable_index_v3.rs:441:12
    |
441 |         if (range_end_addr + self.range_start_nbits as usize + 7) / 8 > data.len() {
    |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.div_ceil()`: `(range_end_addr + self.range_start_nbits as usize).div_ceil(8)`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_div_ceil
    = note: `#[warn(clippy::manual_div_ceil)]` on by default

Check warning on line 186 in common/src/bitset.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

manually reimplementing `div_ceil`

warning: manually reimplementing `div_ceil`
   --> common/src/bitset.rs:186:5
    |
186 |     (max_val + 63u32) / 64u32
    |     ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.div_ceil()`: `max_val.div_ceil(64u32)`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_div_ceil
    = note: `#[warn(clippy::manual_div_ceil)]` on by default

Check warning on line 141 in bitpacker/src/bitpacker.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

manually reimplementing `div_ceil`

warning: manually reimplementing `div_ceil`
   --> bitpacker/src/bitpacker.rs:141:29
    |
141 |         let end_byte_read = (end_bit_read + 7) / 8;
    |                             ^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.div_ceil()`: `end_bit_read.div_ceil(8)`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_div_ceil

Check warning on line 51 in bitpacker/src/bitpacker.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

manually reimplementing `div_ceil`

warning: manually reimplementing `div_ceil`
  --> bitpacker/src/bitpacker.rs:51:29
   |
51 |             let num_bytes = (self.mini_buffer_written + 7) / 8;
   |                             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.div_ceil()`: `self.mini_buffer_written.div_ceil(8)`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_div_ceil
   = note: `#[warn(clippy::manual_div_ceil)]` on by default