Skip to content

In Windows key_list does not return elements when service contains spaces #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
javierluraschi opened this issue Apr 11, 2018 · 1 comment

Comments

@javierluraschi
Copy link
Contributor

This works correctly in Windows,

keyring::key_set_with_value("RStudio", "test", "abc")
> keyring::key_list(service = "RStudio")
  service username
1 RStudio     test

However, this one does not,

keyring::key_set_with_value("RStudio Keyring Secrets", "test", "abc")
keyring::key_list(service = "RStudio Keyring Secrets")
[1] service  username
<0 rows> (or 0-length row.names)

but the key stores correctly, so my guess is that this is a filtering issue:

keyring::key_list()
                  service       username
1                 RStudio           test
2 RStudio Keyring Secrets sqlserver 1689
3 RStudio Keyring Secrets           test

Did a bit of debugging, I think we are just missing to escape, I'll send you a PR...

@gaborcsardi
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants