username could default to the current (system) username

[gaborcsardi]

At least in key_get(), maybe also on key_set().

[anssonliang]

have you solved the key_get() issue where username could default to the current system user?

[gaborcsardi]

You mean this very issue? I guess I haven't, that's why it is still open.

[anssonliang]

Yes, it bugs me when working on appbot. Obviously If the username is included in the key_get(), the error is gone.

keyring::key_get("appbot_api", "SNxxxxxxBG")
[1] "d8xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxkS"

keyring::key_get("appbot_api")
Error in b_wincred_i_get(target) :
Windows credential store error in 'get': Element not found.

[gaborcsardi]

Well, this would make sense, but it is a breaking change at this point, because the username is optional for a key.

Instead, I can introduce an option, which you can set to opt in.