move connection parameters to environment #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanielePalaia
force-pushed
the
move_connection_parameters_to_env
branch
20 times, most recently
from
52646a0 to
b712bf4
Compare
DanielePalaia
changed the title
DanielePalaia
force-pushed
the
move_connection_parameters_to_env
branch
2 times, most recently
from
d9ccd4f to
f94c5be
Compare
DanielePalaia
force-pushed
the
move_connection_parameters_to_env
branch
from
f94c5be to
49b2594
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the Connection parameters (uri, uris, ssl) inside Environment as for other clients (GO, Java) APIs