fix: properly cancel token passed to AsyncEventingBasicConsumer receiver #1789
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ver event on channel close
rhuijben
reviewed
Feb 21, 2025
| @@ -136,6 +136,7 @@ public IEnumerable<string> ConsumerTags | |||
| public int ChannelNumber => InnerChannel.ChannelNumber; | |||
|
|
|||
| public ShutdownEventArgs? CloseReason => InnerChannel.CloseReason; | |||
| public CancellationTokenSource ShutdownCts => InnerChannel.ShutdownCts; | |||
There was a problem hiding this comment.
I think IChannel should expose the token at max, not the writable source.
But there may be cleaner ways to pass this value. The calling function doesn't have cancellation either, and that is the usual way to pass something like that.
There was a problem hiding this comment.
Thanks for taking a look. Yes, I plan on modifying this PR when I get time to work on it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1787