Run rabbit_registry boot step after pre_boot
#13381
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `rabbit_registry` boot step starts up the `rabbit_registry` gen server from `rabbit_common`. This is a registry somewhat similar to the feature flag registry - it's meant to protect an ETS table used for looking up implementers of behaviors. The registry and its ETS table should be available as early as possible: the step should enable external_infrastructure rather than require it.
the-mikedavis
force-pushed
the
md/rabbit-registry-boot-step
branch
from
86f3f6f to
3867012
Compare
michaelklishin
approved these changes
Feb 21, 2025
|
Good catch! |
michaelklishin
added a commit
that referenced
this pull request
Feb 21, 2025
Run `rabbit_registry` boot step after `pre_boot` (backport #13381)
|
This revealed an unusual (or, well, 10 years out of date) choice of boot step dependencies in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
rabbit_registryboot step starts up therabbit_registrygen server fromrabbit_common. This is a registry somewhat similar to the feature flag registry - it's meant to protect an ETS table used for looking up implementers of behaviors. The registry and its ETS table should be available as early as possible: the step should enable external_infrastructure rather than require it.This is a quick fix for #13352. The crash in #13352 occurs because the
databaseboot step runs before therabbit_registryand Khepri deletes transient queues for the local node on during init (and that operation reads from the registry).Fixes #13352