By @ikavgo: introduce a deletion protection marker for queues #13525
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion) (#44) * RMQ-1263: Check if queue protected from deleted inside rabbit_amqqueue:with_delete Delayed exchange automatically manages associated Delayed Queue. We don't want users to delete it accidentally. If queue is indeed protected its removal can be forced by calling with ?INTERNAL_USER as ActingUser. * RMQ-1263: Correct a type spec of amqqueue:internal_owner/1 * RMQ-1263: Add protected queues test --------- Co-authored-by: Iliia Khaprov <[email protected]> Co-authored-by: Michael Klishin <[email protected]> (cherry picked from commit 97f44adfad6d0d98feb1c3a47de76e72694c19e0)
michaelklishin
force-pushed
the
ik-dpc-queue-protection
branch
from
521eb9e to
c69403e
Compare
12 tasks
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This work was originally done by @ikavgo in Tanzu RabbitMQ.
Similarly to internal exchanges, that have restrictions on what applications can do with them,
and virtual hosts that have deletion protection in 4.x, this introduces a deletion protection concept for queues.
This relies on a map property all queues already have, so no schema migrations are necessary.