Skip to content

removing deny tags when there is a tag to sync #196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 25, 2025
Merged

removing deny tags when there is a tag to sync #196

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions pkg/regsync/generateconfig.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ func GenerateConfigFile() error {
return err
}

// Create the regsync config file
// Create the first regsync config file for tracking images and tags on prime registry
if err := createRegSyncConfigFile(imageTagMap); err != nil {
return err
}
Expand Down Expand Up @@ -282,16 +282,18 @@ sync:`)
fmt.Fprintln(file)
fmt.Fprintln(file, " type: repository")
fmt.Fprintln(file, " tags:")
fmt.Fprintln(file, " deny:")
fmt.Fprintln(file, ` - "*"`)
fmt.Fprintln(file, " allow:")

// We collect all tags and then sort them so there is consistency
// in the update of the regsync file always.
tags := make([]string, 0)
tags = append(tags, imageTagMap[repo]...)
if len(tags) == 0 {
fmt.Fprintln(file, " deny:")
fmt.Fprintln(file, ` - "*"`)
continue
}
sort.Strings(tags)

fmt.Fprintln(file, " allow:")
for _, tag := range tags {
if tag == "" {
continue // skip empty tag
Expand Down
Loading