Skip to content

Epinio 1248 add to Marketplace #239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jun 16, 2022

Conversation

andreas-kupries
Copy link
Contributor

@andreas-kupries andreas-kupries commented Apr 29, 2022

Pull Request Checklist

  • Change does not remove any existing Images or Tags in the images-list file
  • Change does not remove / overwrite existing Images or Tags in Rancher DockerHub
  • If updating an existing entry, verify the SOURCE is still accurate and upstream hasn't been migrated to a new registry or repo (if they've migrated, a new repo request to EIO is needed to comply with the SOURCE DESTINATION TAG pattern)
  • New entries are in format SOURCE DESTINATION TAG
  • New entries are added to the correct section of the list (sorted lexicographically)
  • New entries have a repo created in Rancher Dockerhub (where the image will be mirrored to)
  • Changes to scripting or CI config have been tested to the best of your ability

Types of Change

New images to mirror for integration of Epinio with the Rancher Marketplace.

Linked Issues

Epinio ticket epinio/epinio#1248
Rancher PR rancher/charts#1814
General discussion about the work is on #epinio-appsmarketplace-integration
Main contacts @pennyscissors and @SheilaghM

Additional Notes

Final Checks after the PR is merged

  • Confirm that you can pull the new images and tags from DockerHub

@andreas-kupries
Copy link
Contributor Author

Created EIO request - https://github.com/rancherlabs/eio/issues/997

@andreas-kupries andreas-kupries force-pushed the epinio-1248-add-to-marketplace branch from 71a13b6 to 243db86 Compare May 9, 2022 09:32
Copy link
Contributor

@aiyengar2 aiyengar2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have some questions and need @kinarashah to review for the registry image part.

@pennyscissors pennyscissors requested a review from aiyengar2 June 10, 2022 14:56
@andreas-kupries
Copy link
Contributor Author

@aiyengar2
Copy link
Contributor

@andreas-kupries two more comments need to be fixed before merge.

#239 (comment)

#239 (comment)

The existing EIO ticket did not resolve the latter issue with the rancher/mirrored-registry Dockerhub repo

@andreas-kupries
Copy link
Contributor Author

andreas-kupries commented Jun 14, 2022

@aiyengar2 Next EIO request is https://github.com/rancherlabs/eio/issues/1121 - request updated with the minio/mc just added with ff26142

@aiyengar2 aiyengar2 merged commit a39990d into rancher:master Jun 16, 2022
@andreas-kupries andreas-kupries mentioned this pull request Jul 4, 2022
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants