Make accumulator test on DoNotMirror field deterministic #963
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since accumulator.Images() returns a slice of Image(s) picking them from a map, the order of the resulting images is not deterministic (maps element order is unreliable). This may cause sporadic failures of the unit test. Signed-off-by: Francesco Giudici <[email protected]>
fgiudici
changed the title
10 tasks
brandond
approved these changes
Jun 13, 2025
adamkpickering
approved these changes
Jun 13, 2025
There was a problem hiding this comment.
I noticed this as well, but planned to fix it as part of rancher/rancher#50476. In the meantime this is great!
|
Is there an expectation that the accumulator returns images in any particular order? alphabetical or otherwise? |
|
Hey thanks for the review! |
|
@brandond the accumulator doesn't do any sorting. Sorting is done before writing to each file, if necessary. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
Types of Change
Fix sporadic unit test failure, as in https://github.com/rancher/image-mirror/actions/runs/15631022751/job/44035182148?pr=962
Linked Issues
Additional Notes
Since accumulator.Images() returns a slice of Image(s) picking them from a map, the order of the resulting images is not deterministic (maps element order is unreliable).
This may cause sporadic failures of the unit test.
Do the assertions depending on the actual order of the returned images.