Skip to content
This repository was archived by the owner on Dec 8, 2023. It is now read-only.

wrong urls in /sbin/k3os-upgrade-kernel #326

Closed
dxlr8r opened this issue Dec 13, 2019 · 0 comments · Fixed by #327
Closed

wrong urls in /sbin/k3os-upgrade-kernel #326

dxlr8r opened this issue Dec 13, 2019 · 0 comments · Fixed by #327
Labels
kind/bug Something isn't working
Milestone

Comments

@dxlr8r
Copy link

dxlr8r commented Dec 13, 2019

Version
v0.8.0-rc3

Architecture
x86_64

Describe the bug

$ export K3OS_VERSION=v0.8.0-rc3
$ sudo -E /sbin/k3os-upgrade-kernel
Upgrading k3os kernel to Not Found
/sbin/k3os-upgrade-kernel: line 45: cd: too many arguments
ls: cannot access 'current': No such file or directory
ln: failed to create symbolic link './previous': File exists
unlink: cannot unlink 'current': No such file or directory
ln: target 'current' is not a directory
Upgrade complete! Please reboot.

After having looked into this, this is because the url in line 37 is wrong:

KERNEL_VERSION=$(curl -sL https://github.com/rancher/k3os/releases/${K3OS_VERSION}/download/k3os-kernel-version-${ARCH})

Compare this to /sbin/k3os-upgrade-rootfs:

https://github.com/rancher/k3os/releases/download/${K3OS_VERSION}/k3os-rootfs-${ARCH}.tar.gz

And also confirmed that the url is wrong from looking at the urls from GitHub themselves (https://github.com/rancher/k3os/releases).

It should be releases/download/${K3OS_VERSION} and not releases/${K3OS_VERSION}/download.

Line 37 is the first place this occurs, but line 46 and 47 have the same issue:

curl -sL https://github.com/rancher/k3os/releases/${K3OS_VERSION}/download/k3os-initrd-${ARCH} --output initrd
curl -sL https://github.com/rancher/k3os/releases/${K3OS_VERSION}/download/k3os-kernel-${ARCH}.squashfs --output kernel.squashfs
@dweomer dweomer added the kind/bug Something isn't working label Dec 13, 2019
dweomer added a commit to dweomer/k3os that referenced this issue Dec 13, 2019
@dweomer dweomer added this to the v0.8.0 milestone Dec 13, 2019
dweomer added a commit to dweomer/k3os that referenced this issue Dec 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants