Skip to content

Rework strings split_helper utility for better reuse #18575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
May 8, 2025
Merged

Rework strings split_helper utility for better reuse #18575

merged 9 commits into from
May 8, 2025

Conversation

davidwendt
Copy link
Contributor

Description

Part of the strings split refactor work. This change reworks the split_helper internal utility for better reuse with split-on-whitespace and tokenizers (follow on work).

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@davidwendt davidwendt added 2 - In Progress Currently a work in progress libcudf Affects libcudf (C++/CUDA) code. improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Apr 25, 2025
@davidwendt davidwendt self-assigned this Apr 25, 2025
@copy-pr-bot copy-pr-bot
Copy link

copy-pr-bot bot commented Apr 25, 2025

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@davidwendt
Copy link
Contributor Author

/ok to test

@davidwendt davidwendt added 3 - Ready for Review Ready for review by team and removed 2 - In Progress Currently a work in progress labels Apr 30, 2025
@davidwendt
Copy link
Contributor Author

/ok to test

@davidwendt
Copy link
Contributor Author

/ok to test

@davidwendt
Copy link
Contributor Author

/ok to test

@davidwendt davidwendt marked this pull request as ready for review May 1, 2025 18:23
@davidwendt davidwendt requested a review from a team as a code owner May 1, 2025 18:23
@davidwendt davidwendt requested review from devavret and shrshi May 1, 2025 18:23
vyasr
vyasr approved these changes May 7, 2025
View reviewed changes
Copy link
Contributor

@vyasr vyasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't fully understand where you're going with this, but I can see how you might use the flexibility of the templated delimiter for further implementations and the current implementations make sense to me. It seems like mostly code moving around in this PR so I don't see any issues.

@davidwendt
Copy link
Contributor Author

I don't fully understand where you're going with this, but I can see how you might use the flexibility of the templated delimiter for further implementations and the current implementations make sense to me. It seems like mostly code moving around in this PR so I don't see any issues.

Right. The delimiter function is factored out to handle logic for other delimiters (e.g. whitespace, single chars, etc) appropriately in follow on PRs.

@davidwendt
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit a7f1872 into rapidsai:branch-25.06 May 8, 2025
112 checks passed
@davidwendt davidwendt deleted the split-utils-rework branch May 8, 2025 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vyasr vyasr vyasr approved these changes

@devavret devavret devavret approved these changes

@shrshi shrshi shrshi approved these changes

@ttnghia ttnghia ttnghia approved these changes

Assignees

@davidwendt davidwendt

Labels
3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@davidwendt @vyasr @devavret @shrshi @ttnghia