Link to nvtx3::nvtx3-cpp instead of nvToolsExt
#18730
Merged
+24
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
libcudf
jakirkham
added
bug
davidwendt
approved these changes
May 9, 2025
|
/merge |
|
Thanks Bradley and David! 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Cherry-picking and squashing Bradley's commits: 35b78d8 & c574119
As part of CUDA 12.9 bringup, we found that cuDF is linking to the legacy
nvToolsExtlibrary, which is dropped in that CUDA release. However cuDF no longer uses the legacynvToolsExtlibrary since upgrading to NVTX 3.In the rest of the code, we use the
nvtx3::nvtx3-cpptarget. So this replaces the fewnvToolsExtusages with the new/preferred target.Checklist