Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enable Netty leak detector extension #3064

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

enable Netty leak detector extension #3064

wants to merge 1 commit into from

Conversation

sullis
Copy link
Contributor

@sullis sullis commented Feb 18, 2024 •
edited
Loading

@sullis sullis force-pushed the NettyLeakDetectorExtension branch 2 times, most recently from 4a3f1b3 to abc1bb1 Compare February 25, 2024 04:36
@violetagg violetagg added the type/enhancement A general enhancement label Mar 15, 2024
@sullis sullis force-pushed the NettyLeakDetectorExtension branch 3 times, most recently from 1649d9c to fea9ce8 Compare March 22, 2024 17:36
@sullis
Copy link
Contributor Author

sullis commented Mar 22, 2024

I observed a failure in GitHub Actions

ubuntu-20.04

image 
Http2Tests > testHttp2ForMemoryLeaks() FAILED
    java.lang.IllegalStateException: Netty leaks: after [testHttp2ForMemoryLeaks()] [ByteBuf, ByteBuf, ByteBuf, ByteBuf, ByteBuf, ByteBuf, ByteBuf, ByteBuf, ByteBuf, ByteBuf]
        at io.github.nettyplus.leakdetector.junit.NettyLeakListener.assertZeroLeaks(NettyLeakListener.java:31)
image

@sullis sullis force-pushed the NettyLeakDetectorExtension branch 3 times, most recently from 7c864c5 to ea72399 Compare March 29, 2024 19:03
@sullis sullis force-pushed the NettyLeakDetectorExtension branch 2 times, most recently from a5abd65 to cb3b889 Compare April 17, 2024 00:15
@sullis
Copy link
Contributor Author

sullis commented Apr 17, 2024

GitHub Actions CI:

Http2Tests > testHttp2ForMemoryLeaks() FAILED
    java.lang.IllegalStateException: Netty leaks: after [testHttp2ForMemoryLeaks()] [ByteBuf, ByteBuf, ByteBuf, ByteBuf, ByteBuf, ByteBuf, ByteBuf, ByteBuf, ByteBuf, ByteBuf, ByteBuf]
        at io.github.nettyplus.leakdetector.junit.NettyLeakListener.assertZeroLeaks(NettyLeakListener.java:31)

@sullis sullis force-pushed the NettyLeakDetectorExtension branch 3 times, most recently from a0a3017 to 9fc0757 Compare May 20, 2024 15:36
@sullis sullis force-pushed the NettyLeakDetectorExtension branch from 9fc0757 to 306ba93 Compare July 9, 2024 13:38
@sullis sullis force-pushed the NettyLeakDetectorExtension branch from 100ad03 to 87d0929 Compare February 17, 2025 01:18
violetagg
violetagg requested changes Feb 17, 2025
View reviewed changes
reactor-netty-core/src/test/java/reactor/netty/ByteBufMonoTest.java
@@ -1,5 +1,5 @@
/*
* Copyright (c) 2020-2021 VMware, Inc. or its affiliates, All Rights Reserved.
* Copyright (c) 2020-2024 VMware, Inc. or its affiliates, All Rights Reserved.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Copyright (c) 2020-2024 VMware, Inc. or its affiliates, All Rights Reserved.
* Copyright (c) 2020-2025 VMware, Inc. or its affiliates, All Rights Reserved.

reactor-netty-core/src/test/java/reactor/netty/ConnectionTest.java
@@ -1,5 +1,5 @@
/*
* Copyright (c) 2017-2023 VMware, Inc. or its affiliates, All Rights Reserved.
* Copyright (c) 2017-2024 VMware, Inc. or its affiliates, All Rights Reserved.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Copyright (c) 2017-2024 VMware, Inc. or its affiliates, All Rights Reserved.
* Copyright (c) 2017-2025 VMware, Inc. or its affiliates, All Rights Reserved.

reactor-netty-core/src/test/java/reactor/netty/ByteBufFluxTest.java
@@ -1,5 +1,5 @@
/*
* Copyright (c) 2017-2022 VMware, Inc. or its affiliates, All Rights Reserved.
* Copyright (c) 2017-2024 VMware, Inc. or its affiliates, All Rights Reserved.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Copyright (c) 2017-2024 VMware, Inc. or its affiliates, All Rights Reserved.
* Copyright (c) 2017-2025 VMware, Inc. or its affiliates, All Rights Reserved.

@sullis sullis force-pushed the NettyLeakDetectorExtension branch from 87d0929 to 52fd009 Compare February 27, 2025 13:25
@violetagg
Copy link
Member

@sullis The build for this PR is not able to pass because it misses my suggestions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@violetagg violetagg violetagg requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
type/enhancement A general enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sullis @violetagg