Preserve the order of the array with all and map functions #77
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WyriHaximus
approved these changes
Dec 22, 2016
jsor
requested changes
Dec 22, 2016
| call_user_func($queue->dequeue()); | ||
|
|
||
| $this->assertSame([1, 2, 3], $result); | ||
| } |
There was a problem hiding this comment.
I'd like to see the style of the test matching the rest of the tests. In this case this would something like
/** @test */
public function shouldPreserveTheOrderOfArrayWhenResolvingAsyncPromises()
{
$deferred = new Deferred();
$mock = $this->createCallableMock();
$mock
->expects($this->once())
->method('__invoke')
->with($this->identicalTo([1, 2, 3]));
all([1, $deferred->promise(), 3])
->then($mock);
$deferred->resolve(2);
}| $this->assertSame([2 ,4 ,6], $result); | ||
| } | ||
|
|
||
| /** @test */ |
There was a problem hiding this comment.
I'd like to see the style of the test matching the rest of the tests (see my comment on the all test).
clue
approved these changes
Dec 22, 2016
|
@jsor Unified the test style. Sorry about that :). |
jsor
approved these changes
Dec 22, 2016
|
Awesome, thanks a lot @lordthorzonus! |
|
Released in v2.5.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #74
I added the changelog entry for the 2.5.x heading (not sure if this is correct).