Skip to content

fix: dont initialize mermaid #1093

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 25, 2025
Merged

fix: dont initialize mermaid #1093

merged 1 commit into from
Apr 25, 2025

Conversation

kellyjosephprice
Copy link
Collaborator

@kellyjosephprice kellyjosephprice commented Apr 25, 2025 •
edited
Loading

PR App Fix RM-12558

🧰 Changes

Only initializes mermaid if a mermaid element is present in the DOM.

flamegraphs are cool

THe first big spike is react, the second is mermaid. The rest of the smaller is each diagram (I believe)
image

🧬 QA & Testing

@kellyjosephprice kellyjosephprice requested review from kevinports and a team April 25, 2025 19:43
@kellyjosephprice kellyjosephprice marked this pull request as ready for review April 25, 2025 19:43
kevinports
kevinports approved these changes Apr 25, 2025
View reviewed changes
Copy link
Contributor

@kevinports kevinports left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🫶 thank you. I was looking at this code the other day and totally mis-read it, but glad you caught this. Should make a big difference!

@kellyjosephprice kellyjosephprice merged commit 30989fa into next Apr 25, 2025
14 checks passed
@kellyjosephprice kellyjosephprice deleted the fix/dont-initialize-mermaid branch April 25, 2025 19:52
rafegoldberg pushed a commit that referenced this pull request Apr 25, 2025
@semantic-release-bot
build(release): 🚀 v9.2.2 🦉
700da63 
## Version 9.2.2
### 🛠 Fixes & Updates

* dont initialize mermaid ([#1093](#1093)) ([30989fa](30989fa))

<!--SKIP CI-->
@rafegoldberg
Copy link
Contributor

This PR was released!

🚀 Changes included in v9.2.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevinports kevinports kevinports approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kellyjosephprice @rafegoldberg @kevinports