Skip to content

Format Laravels ValidationException the same way as a ValidationError #748

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 16, 2021

Conversation

mfn
Copy link
Collaborator

@mfn mfn commented Apr 16, 2021

Summary

This way it's as easy as just letting the validator throw from any resolver and doesn't require the provided ValidationError thrown from the internal validation.

See also #716 (comment)


Type of change:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Misc. change (internal, infrastructure, maintenance, etc.)

Checklist:

  • Existing tests have been adapted and/or new tests have been added
  • Add a CHANGELOG.md entry
  • Update the README.md
  • Code style has been fixed via composer fix-style

@mfn mfn self-assigned this Apr 16, 2021
@mfn mfn force-pushed the mfn-laravel-validation-exc branch from c6b48d7 to 4e10f0d Compare April 16, 2021 21:49
@mfn mfn force-pushed the mfn-laravel-validation-exc branch from 4e10f0d to da80031 Compare April 16, 2021 21:50
@mfn mfn merged commit 75ca540 into master Apr 16, 2021
@mfn mfn deleted the mfn-laravel-validation-exc branch April 16, 2021 21:52
@mfn mfn added this to the 8.0.0 milestone May 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant