Tweak block size for lfs tests while on SCORPIO_FLASH. #27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brudley
commented
Jun 29, 2021
brudley
commented
- Also skip leading slash test
* Also skip leading slash test
sabhiram
approved these changes
Jun 29, 2021
| @@ -62,10 +62,23 @@ static int clean_statvfs(const struct fs_mount_t *mp) | |||
| stat.f_bsize, stat.f_frsize, stat.f_blocks, stat.f_bfree); | |||
| zassert_equal(stat.f_bsize, 16, | |||
| "bsize fail"); | |||
| #ifdef CONFIG_SCORPIO_FLASH | |||
There was a problem hiding this comment.
Looks good to me, we can always make the two numbers into config vars if needed, for now the comment explains things well :)
sabhiram
pushed a commit
that referenced
this pull request
Aug 12, 2021
* Also skip leading slash test
sabhiram
pushed a commit
that referenced
this pull request
Sep 17, 2021
* Also skip leading slash test
sabhiram
pushed a commit
that referenced
this pull request
Sep 17, 2021
* Also skip leading slash test
berendo
pushed a commit
that referenced
this pull request
Dec 17, 2021
* Also skip leading slash test
berendo
pushed a commit
that referenced
this pull request
Dec 20, 2021
* Also skip leading slash test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.