adding glm_vec2_center #350
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @duarm, Thanks, is it possible to add this function to struct api (include/cglm/struct/) and docs/ too, otherwise I'll do it later after merge the PR. |
|
I can do it no prob |
|
done, I've already added the docs to docs/source/vec2.rst, couldn't find the struct api docs, if there is such a thing |
|
@duarm many thanks, the PR is merged 🚀
Since it is same job, there is no need to duplicate docs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
new glm_vec2_center function, there's already a vec3 version, this will be useful for when we implement 2d aabb