-
Notifications
You must be signed in to change notification settings - Fork 185
DFBUGS-2040: [release 4.14] Add managedBy label to localecephrules #3134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: release-4.14
Are you sure you want to change the base?
DFBUGS-2040: [release 4.14] Add managedBy label to localecephrules #3134
Conversation
@aruniiird: This pull request references [Jira Issue DFBUGS-2040](https://issues.redhat.com//browse/DFBUGS-2040), which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@umangachapagain , @iamniting , can we approve this PR (as this is linked with a customer case)? |
@aruniiird Can you get acks on the BZ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was this backported to 4.15 already?
We shouldn't have a backport to 4.14 unless that is done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just verified that these changes are not present in release-4.15. Please create a backport to 4.15 first.
Also, I noticed that some of these changes here are not even on latest releases. So please either add those changes to all releases or remove it from here for consistency. For example record: cluster:ceph_disk_latency:join_ceph_node_disk_irate1m
recording rule changes.
Signed-off-by: Arun Kumar Mohan <[email protected]>
a35ef2b
to
53fbee7
Compare
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: aruniiird The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Created a backport PR#3188 for 4.15 release branch. |
BZ: https://issues.redhat.com/browse/DFBUGS-2040
We have already added
managedBy
label to odf prometheus queries. This is a kind of backport PR from 4.16