Skip to content

DFBUGS-2040: [release 4.14] Add managedBy label to localecephrules #3134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: release-4.14
Choose a base branch
from

Conversation

aruniiird
Copy link
Contributor

BZ: https://issues.redhat.com/browse/DFBUGS-2040

We have already added managedBy label to odf prometheus queries. This is a kind of backport PR from 4.16

@aruniiird aruniiird changed the title [release 4.14] add managed by label to localecephrules DFBUGS-2040: [release 4.14] Add managedBy label to localecephrules Apr 4, 2025
@openshift-ci-robot openshift-ci-robot added jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid jira ticket of any type jira/invalid-bug Indicates that the referenced jira bug is invalid for the branch this PR is targeting labels Apr 4, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 4, 2025

@aruniiird: This pull request references [Jira Issue DFBUGS-2040](https://issues.redhat.com//browse/DFBUGS-2040), which is invalid:

  • expected the bug to target the "odf-4.14.18" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

BZ: https://issues.redhat.com/browse/DFBUGS-2040

We have already added managedBy label to odf prometheus queries. This is a kind of backport PR from 4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@aruniiird
Copy link
Contributor Author

@umangachapagain , @iamniting , can we approve this PR (as this is linked with a customer case)?

@iamniting
Copy link
Member

@aruniiird Can you get acks on the BZ?

Copy link
Contributor

@umangachapagain umangachapagain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this backported to 4.15 already?
We shouldn't have a backport to 4.14 unless that is done.

Copy link
Contributor

@umangachapagain umangachapagain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just verified that these changes are not present in release-4.15. Please create a backport to 4.15 first.

Also, I noticed that some of these changes here are not even on latest releases. So please either add those changes to all releases or remove it from here for consistency. For example record: cluster:ceph_disk_latency:join_ceph_node_disk_irate1m recording rule changes.

@aruniiird aruniiird force-pushed the release-4.14-add-managedBy-label-to-localecephrules branch from a35ef2b to 53fbee7 Compare April 23, 2025 05:33
Copy link
Contributor

openshift-ci bot commented Apr 23, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: aruniiird
Once this PR has been reviewed and has the lgtm label, please ask for approval from umangachapagain. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@aruniiird
Copy link
Contributor Author

Created a backport PR#3188 for 4.15 release branch.
Please take a look
PS: I've removed any changes which are not there in master/4.16+ branches, will create a separate PR to only add those changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jira/invalid-bug Indicates that the referenced jira bug is invalid for the branch this PR is targeting jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid jira ticket of any type
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants