added pre-commit for end-of-file-fixer and trailing-whitespace

[garethahealy]

enables below checks and added a github action to run checks

• end-of-file-fixer
• trailing-whitespace

cc: @redhat-cop/day-in-the-life

[garethahealy]

the failing test update-clusterversion looks like it's never worked (#535) and never will because it's an OCP resource, so wont work on kind

[itewk]

@redhat-cop/day-in-the-life i feel like this should be reviewed by more then just me...

[garethahealy]

@ckavili @eformat you ok to review/merge based on above comment

[itewk]

@garethahealy i am trying to figure out why install test isn't passing. i have seen sometimes it just starts timing out. but then like late at night it doesnt.

the lint test though....

[garethahealy]

see this comment #618 (comment) - update-clusterversion needs excluding via https://github.com/redhat-cop/helm-charts/blob/main/_test/ct-config.yaml

[ckavili]

wow such changes 🙈 LGTM 🚀 thanks Gareth!

[itewk]

see this comment #618 (comment) - update-clusterversion needs excluding via https://github.com/redhat-cop/helm-charts/blob/main/_test/ct-config.yaml

aaah. okay.

Mind opening another PR for that, we can merge that quick, and then rebase and merge this?

[garethahealy]

see this comment #618 (comment) - update-clusterversion needs excluding via https://github.com/redhat-cop/helm-charts/blob/main/_test/ct-config.yaml

aaah. okay.

Mind opening another PR for that, we can merge that quick, and then rebase and merge this?

#638

[itewk]

@garethahealy cam you rebase now so we can get the clean run?

[garethahealy]

@garethahealy cam you rebase now so we can get the clean run?

already done

[ckavili]

I am merging it then if there is no objection? 🦭 👯‍♂️

[itewk]

@garethahealy @ckavili thanks!