Skip to content

fix: Add missing impersonate rule #845

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

varshab1210
Copy link
Member

What type of PR is this?

/kind enhancement

What does this PR do / why we need it:

Update argocd operator commit for adding missing permission in application controller clusterrole

Have you updated the necessary documentation?

  • Documentation update is required by this PR.
  • Documentation has been updated.

Which issue(s) this PR fixes:

Fixes #?

Test acceptance criteria:

  • Unit Test
  • E2E Test

How to test changes / Special notes to the reviewer:

@openshift-ci openshift-ci bot added the kind/enhancement New feature or request label Feb 20, 2025
@varshab1210 varshab1210 changed the title Add impersonation permission Update argocd operator commit 97b2763 Feb 20, 2025
@varshab1210
Copy link
Member Author

varshab1210 commented Feb 20, 2025

Adding changes in openshift.go was populating two entries so I have avoided that

  - verbs:
      - impersonate
    apiGroups:
      - ''
    resources:
      - serviceaccounts
  - verbs:
      - impersonate
    apiGroups:
      - ''
    resources:
      - serviceaccounts

cc: @svghadi

@svghadi
Copy link
Member

svghadi commented Feb 21, 2025

Adding changes in openshift.go was populating two entries so I have avoided that

  - verbs:
      - impersonate
    apiGroups:
      - ''
    resources:
      - serviceaccounts
  - verbs:
      - impersonate
    apiGroups:
      - ''
    resources:
      - serviceaccounts

cc: @svghadi

I see impersonate changes in openshift.go. Are this changes reflected in the PR?

@varshab1210 varshab1210 force-pushed the add-impersonation-permission branch from 201fecc to 7a73c69 Compare February 25, 2025 06:12
@svghadi svghadi changed the title Update argocd operator commit 97b2763 fix: Add missing impersonate rule Feb 25, 2025
@svghadi
Copy link
Member

svghadi commented Feb 25, 2025

/lgtm
/approve

Copy link

openshift-ci bot commented Feb 25, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: svghadi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@svghadi
Copy link
Member

svghadi commented Feb 25, 2025

/retest

@varshab1210
Copy link
Member Author

/test v4.14-kuttl-parallel

@varshab1210
Copy link
Member Author

/test v4.17-e2e

@openshift-merge-bot openshift-merge-bot bot merged commit 01738f4 into redhat-developer:master Feb 25, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants