-
Notifications
You must be signed in to change notification settings - Fork 318
fix: Add missing impersonate rule #845
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Add missing impersonate rule #845
Conversation
Adding changes in openshift.go was populating two entries so I have avoided that
cc: @svghadi |
I see impersonate changes in |
Signed-off-by: Varsha B <[email protected]>
Signed-off-by: Varsha B <[email protected]>
201fecc
to
7a73c69
Compare
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: svghadi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
/test v4.14-kuttl-parallel |
/test v4.17-e2e |
01738f4
into
redhat-developer:master
What type of PR is this?
/kind enhancement
What does this PR do / why we need it:
Update argocd operator commit for adding missing permission in application controller clusterrole
Have you updated the necessary documentation?
Which issue(s) this PR fixes:
Fixes #?
Test acceptance criteria:
How to test changes / Special notes to the reviewer: