Skip to content

chore: run eslint as pre-commit.ci hook #1894

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ssbarnea
Copy link
Member

@ssbarnea ssbarnea commented May 22, 2025

  • pre-commit.ci hook config (can use GHA app or local)
  • enable eslint GHA output support that produce GHA annotations
  • upgraded unsupported .eslintignore file

Before submitting your PR, please review the following checklist:

  • CONSIDER adding a new test if your PR resolves an issue.
  • DO keep pull requests small so they can be easily reviewed.
  • DO make sure tests pass.
  • DO make sure any public APIs changes are documented.
  • DO make sure not to introduce any compiler warnings.

Before merging the PR:

  • CHECK continuous integration of main branch is green.
  • CHECK pull request check job is green.
  • CHECK all pull request questions/requests are resolved.
  • WAIT till PR is approved by at least 1 committer.

- pre-commit.ci hook config (can use GHA app or local)
- enable eslint GHA output support that produce GHA annotations
- upgraded unsupported .eslintignore file
@ssbarnea ssbarnea force-pushed the fix/1853-getFile-resilient branch from fbd5a90 to 49deb57 Compare May 22, 2025 13:13
@ssbarnea ssbarnea marked this pull request as ready for review May 22, 2025 13:15
@ssbarnea ssbarnea requested a review from a team as a code owner May 28, 2025 10:18
Copy link

@djelinek djelinek added question Further information is requested rebase-required Conflicts with main branch, need to rebase labels Jun 5, 2025
@djelinek
Copy link
Collaborator

djelinek commented Jun 5, 2025

Hello, can you please elaborate more how this config is working what are the benefits please? When we are following local dev setup the code should be well formatted and validated already?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested rebase-required Conflicts with main branch, need to rebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants