-
Notifications
You must be signed in to change notification settings - Fork 222
add link icon to section headers #1755
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! This seems to work great on most pages I've checked. The only issue I've found so far is that the links that should appear in the "On this page" ToC on the right-hand side have disappeared for some pages that include embeds.
Before this change: https://redis.io/docs/latest/operate/rs/references/supported-platforms/
Versus after this change: https://redis.io/docs/staging/link-icon-poc/operate/rs/references/supported-platforms/
I think this issue might only affect pages where headers are included within the embed content, because other pages with embeds like https://redis.io/docs/staging/link-icon-poc/operate/rs/installing-upgrading/quickstarts/redis-enterprise-software-quickstart/ seem to be fine.
Nice improvement :-) Just a couple of thoughts:
|
Another example RE: Embed header weirdness - Compatibility page - before: https://redis.io/docs/latest/operate/rs/references/compatibility It's also on the Cloud page, but they're basically the same. Any headers in that embed file don't show in the right-side TOC. |
@rrelledge and @andy-stark-redis, I had augmented make some edits based on your feedback. It looks like it fixed Andy's suggestions, but the TOC weirdness Rachel and @cmilesb pointed out is still happening |
@kaitlynmichael @cmilesb I pushed a fix for the "On this page" ToC for embeds. It seems like it's working now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that worked, @rrelledge - looks good to me.
DOC-5370
Suggestion from #ask-docs https://redis.slack.com/archives/C02QBGV0LUS/p1750859040153789