Skip to content

Sentinel host is changed to be system independent #1719

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

sazzad16
Copy link
Contributor

@sazzad16 sazzad16 commented Dec 19, 2017

Fixes #1367

Couldn't add any test because of system dependency.

@sazzad16 sazzad16 added this to the 2.9.1 milestone Dec 19, 2017
@sazzad16
Copy link
Contributor Author

@HeartSaVioR @marcosnils

@marcosnils
Copy link
Contributor

@sazzad16 I'm not sure if this is the right alternative for the fix. Seems like #1342 should be reworked to handle all non-system dependent scenarios. Patching this only for sentinel doesn't feel right

@sazzad16
Copy link
Contributor Author

@marcosnils Sentinel is probably the only case where host:port formatted string is being taken from users. So, IMHO, this exception can be acceptable.

@sazzad16 sazzad16 force-pushed the sentinelpool-hostport branch from f82a468 to c2fd66f Compare December 22, 2017 06:10
@sazzad16 sazzad16 modified the milestones: 2.9.1, 2.10.0 Aug 13, 2018
@gkorland gkorland modified the milestones: 2.10.0, 3.1.0 Dec 6, 2018
@sazzad16 sazzad16 modified the milestones: 3.1.0, 3.2.0 Jul 17, 2019
@gkorland gkorland modified the milestones: 3.2.0, 3.3.0 Nov 25, 2019
@sazzad16 sazzad16 modified the milestones: 3.3.0, 3.4.0 Mar 14, 2020
@sazzad16 sazzad16 modified the milestones: 3.4.0, 3.5.0 Nov 26, 2020
@sazzad16 sazzad16 removed this from the 3.5.0 milestone Dec 9, 2020
@sazzad16
Copy link
Contributor Author

Closing in favor of #2445 which is available since Jedis 3.6.0.
Reference: #1367 (comment)

@sazzad16 sazzad16 closed this Jul 14, 2021
@sazzad16 sazzad16 deleted the sentinelpool-hostport branch July 14, 2021 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Loopback host address ('localhost','127.0.0.1', etc.) resolves to network IP
3 participants