Sentinel tls support #2232
Closed
Sentinel tls support #2232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sazzad16
suggested changes
Aug 24, 2020
MattiasLass
force-pushed
the
sentinel-tls-support
branch
from
9bfa2c4 to
48186cd
Compare
sazzad16
previously approved these changes
Aug 25, 2020
bsbodden
reviewed
Jan 14, 2021
sazzad16
suggested changes
Jan 14, 2021
Comment on lines
-347
to
+362
| public MasterListener(String masterName, String host, int port) { | ||
| public MasterListener(String masterName, String host, int port, boolean isSslEnabled, | ||
| SSLSocketFactory sslSocketFactory, SSLParameters sslParameters, HostnameVerifier hostnameVerifier) { |
There was a problem hiding this comment.
This breaks backward compatibility.
sazzad16
force-pushed
the
sentinel-tls-support
branch
from
84ba9e9 to
48186cd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've implemented the requested changes from #2139, as the progress on the original PR seems to have stopped.