Topology updated if unchanged

[ajs139]

Bug Report

Looking at the code in RedisClusterClient.refreshPartitionsAsync it seems like the partitions are updated even when it has been determined they haven't changed:

https://github.com/lettuce-io/lettuce-core/blob/70022607cf8ab2fb45d6814372b20da90aae2be3/src/main/java/io/lettuce/core/cluster/RedisClusterClient.java#L891-L905

Was curious if this is intentional?

Environment

• Lettuce version(s): any
• Redis version: any

Additional context

[YoHanKi]

Hello,

I would like to confirm whether this issue has already been resolved. If further modifications are needed, I would be happy to contribute, albeit modestly.

From my understanding, the problem is that updateCache() is being called every time—even when there is no change in the topology—resulting in the creation of new collections repeatedly. Therefore, I believe that partitions.reload() should not be executed if TopologyComparators.isChanged() returns false. Could you please confirm if this understanding is correct?

Additionally, I would appreciate guidance on which test cases would be appropriate to verify this fix once the issue is resolved.

Thank you, and I look forward to your response.

[tishun]

Hey @YoHanKi ,

The issue is not resolved. If you wish you can submit a PR and the team would check it once we have some time.