hash parsing issue #124
hash parsing issue #124
Conversation
| @@ -348,14 +348,29 @@ private static string SendToJson(IDictionary<string, string> hash, Type t) | |||
|
|
|||
| if (type == typeof(bool) || type == typeof(bool?)) | |||
| { | |||
| if (!hash.ContainsKey(propertyName)) | |||
There was a problem hiding this comment.
Maybe instead of writing this if 3 time, changing line 344 to: if (!hash.Any(x => x.Key == propertyName)) {continue;} will be more efficient.
If I understood you correctly, the line that I offered sepose to include the cases of the if's..
@slorello89 what do you think? am I missing somthing?
There was a problem hiding this comment.
if only it were that easy, the thing is, you only check this if the underpinning type is not an enumerable and is not another object, the reason for this, if it's an array the property name should start with propertyname[, and if it's an object with sub-fields that we want to expand, it needs to start with propertyname., so really the only valid time to check this is these three scenarios, hence the slight duplication between the three.
There was a problem hiding this comment.
Sounds logical, I thought there was a nicer way to do it, but you know the code better than I do.
Fixing issue with hash hydration caused by multiple prefixes matching the property name, this is caused by the way we handle serializing collections within hashes and embedded hashes within hashes, just need to check that the property is in what's reported back from Redis. Fixes #120