feat: Create and alias index #813
Open
+237
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rueian
reviewed
Mar 26, 2025
rueian
reviewed
Mar 31, 2025
rueian
reviewed
Apr 4, 2025
|
Hi @SoulPancake, I just reviewed it again and left some comments. Could you also write some tests to demonstrate how a user can use this feature? |
SoulPancake
commented
Apr 9, 2025
rueian
reviewed
Apr 9, 2025
om/hash.go
Outdated
| var currentIndex string | ||
| infoCmd := r.client.B().FtInfo().Index(alias).Build() | ||
| infoResp, err := r.client.Do(ctx, infoCmd).ToMap() | ||
| aliasExists := err == nil |
There was a problem hiding this comment.
What will be the error returned when the index does not exist? Will it be a redis Nil? I think we should return early here if the err is caused by other reasons, such as network failures.
Co-authored-by: Rueian <[email protected]>
SoulPancake
commented
Apr 9, 2025
|
Hi @rueian Apologies for the huge delay |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.