Fix image selection #58
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change fixes a bug that can be reproduced by:
1. Run the development app
2. Paste an image into the editor
3. Select all
4. The "remote" cursor does not highlight the image, and the console
errors
This is because when using `Range.setStart` and `Range.setEnd`, the
`offset` argument is treated differently for non-text nodes.
This change updates our range definitions to check if the leaf in
question is a text node or not. If it is a text node, then we use the
offset as before. However, if it isn't a text node (eg an `img`), then
we simply set the selection before/after the node using
`Range.setStartBefore` and `Range.setEndAfter`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #57
This change fixes a bug that can be reproduced by:
errors
This is because when using
Range.setStartandRange.setEnd, theoffsetargument is treated differently for non-text nodes.This change updates our range definitions to check if the leaf in
question is a text node or not. If it is a text node, then we use the
offset as before. However, if it isn't a text node (eg an
img), thenwe simply set the selection before/after the node using
Range.setStartBeforeandRange.setEndAfter.