🐛 Fix ResizeObserver limit loop #87
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alecgibson
reviewed
Jan 20, 2023
After the last Chrome's update to version 109, there is the issue with `ResizeObserver limit loop`, because of infinity loop. It happens because we **always** update cursors, which registers the new observer. Let's return from the function and prevent creating new observer for cases, when it should stop observing
fyvfyv
force-pushed
the
fix-resize-observer-loop
branch
from
d4e00f5 to
e5efba4
Compare
alecgibson
approved these changes
Jan 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After the last Chrome's update to version 109, there is the issue with
ResizeObserver limit loop, because of infinity loop. It happens because we always update cursors, which registers the new observer. Let's return from the function and prevent creating new observer for cases, when it should stop observing