Skip to content

chore: remove lib, refactor tests, and improve types #529

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Oct 16, 2023

Conversation

remarkablemark
Copy link
Owner

Relates to #527

What is the motivation for this pull request?

chore: remove lib, refactor tests, and improve types

What is the current behavior?

lib is checked in git

Server mocha tests are in vanilla JS

Parser using incorrect argument type

ESLint outdated

What is the new behavior?

lib is gitignored

Server mocha tests are migrated to TS

Fixed parser argument type

ESLint updated

Checklist:

@remarkablemark remarkablemark added dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code labels Oct 16, 2023
@remarkablemark remarkablemark self-assigned this Oct 16, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 16, 2023

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
dist/html-dom-parser.min.js 2.25 KB (0%) 45 ms (0%) 42 ms (+149.96% 🔺) 87 ms

@remarkablemark remarkablemark merged commit 3997ab3 into master Oct 16, 2023
@remarkablemark remarkablemark deleted the chore/lib branch October 16, 2023 06:37
@remarkablemark
Copy link
Owner Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant