fix: work on environments without import.meta.resolve
#13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
remcohaszing
requested changes
Mar 19, 2025
| const resolve: (path: string) => string = | ||
| import.meta.resolve || ((path) => new URL(path, import.meta.url).href); | ||
|
|
||
| const html = resolve('../index.html') |
There was a problem hiding this comment.
This is fine, but it could also be written as:
Suggested change
| const html = resolve('../index.html') | |
| const html = String(new URL('../index.html')) |
| const mermaidScript = { | ||
| url: import.meta.resolve('mermaid/dist/mermaid.js') | ||
| url: resolve('mermaid/dist/mermaid.js') |
There was a problem hiding this comment.
This won’t work. This is a bare import specifier that must resolve into node_modules.
| } | ||
| const faStyle = { | ||
| // We use url, not path. If we use path, the fonts can’t be resolved. | ||
| url: import.meta.resolve('@fortawesome/fontawesome-free/css/all.css') | ||
| url: resolve('@fortawesome/fontawesome-free/css/all.css') |
|
Ahhh I see your concerns, it seems I didn't think of that. Thanks for your reply! I'll see if there's another way to achieve this. |
|
I’m open to suggestions, but unfortunately I don’t see a path forward. I’m closing this PR for now. The goal of this PR isn’t to make it work in environments that don’t support |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See nodejs/nodejs.org#7544 for reference.