fix default case for responseType in WireClient._fetchRequest #1151 #1152
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If no responseType property is present in options parameter to WireClient._fetchRequest, the function defaults to document and throws an error. If responseType is undefined, the function should treat the response as text. Also, if the response is treated as text, the syntheticXhr.responseText property should be set to processedBody in order to not break XHR compatibility.
|
This code looks fine. It would be nice to have the tests in dropbox-suite and googledrive-suite run for both XHR and fetch, as is done in wireclient-suite. |
silverbucket
previously requested changes
Jan 9, 2019
|
i will try and refactor the dropbox-suite and googledrive-suite and include tests for fetch when i get some time |
refactored wireclient-suite, dropbox-suite and googledrive-suite to use common code for XHR and fetch() mocks, so now dropbox-suite and googledrive-suite will also test using fetch() beside XHR. fixed a test in dropbox-suite. added a test for WireClient when responseType is not set
|
I can confirm that this fixes both Dropbox and GDrive when compared to Good job, @iLiviu! 👏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If no responseType property is present in options parameter to WireClient._fetchRequest,
the function defaults to document and throws an error. If responseType is undefined,
the function should treat the response as text. Also, if the response is treated as text,
the syntheticXhr.responseText property should be set to processedBody in order to not
break XHR compatibility.