Fix GitHub Actions Workflow #1224
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raucao
reviewed
Mar 8, 2021
.github/workflows/test-and-lint.yml
Outdated
| @@ -20,7 +20,7 @@ jobs: | |||
| - name: Install dependencies | |||
| run: npm install | |||
| - name: Compile TypeScript | |||
| run: tsc | |||
| run: npx tsc | |||
There was a problem hiding this comment.
The npm test script in package.json actually includes compiling TypeScript already, so I think this step is not necessary.
There was a problem hiding this comment.
I agree 👍 I wasn't sure exactly why this separate tsc was called out in the first place, other than a sanity check, but I'll go ahead and remove this step.
There was a problem hiding this comment.
Yeah, just saw that it was already unnecessarily called on Travis. Just an oversight when we were working on the whole TS port I guess.
Testing this locally with https://github.com/nektos/act, I was able to reproduce the issue and fix it with this change. Now that the workflow has been commited to the repository, hopefully it will be easier to test and check. Also, remove redundant `tsc` in CI pipeline since `tsc` is called inside `npm test`.
pjbollinger
force-pushed
the
bugfix/fix-github-workflow
branch
from
dcfa54e to
d3c54dd
Compare
|
🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing this locally with https://github.com/nektos/act, I was able to reproduce the issue and fix it with this change.
Now that the workflow has been committed to the repository, hopefully it will be easier to test and check.
Apologies for the additional PR, I should have looked to see how to test it locally before committing. 😅