feat: Repository cache git backend #34324
Conversation
lib/util/git/repo-store.ts
Outdated
| } | ||
| logger.debug(`Git commit created: ${commitSha}`); | ||
|
|
||
| const refName = `refs/renovate-data/${key}`; |
There was a problem hiding this comment.
Do you think we should separate refs/renovate from refs/renovate-data? e.g. not refs/renovate/data/*?
There was a problem hiding this comment.
Then we need to change the branches we do for platform-based commits
There was a problem hiding this comment.
Otherwise I guarantee we'll get a weird bug some day
There was a problem hiding this comment.
Yes, let's do that then. Have everything under refs/renovate/<something>/*
There was a problem hiding this comment.
BTW I thought you used refs/renovate/branches/* already
There was a problem hiding this comment.
Yes, but maybe let's have them under refs/renovate/tmp/*, to be clear they're subject to cleanup
| const commitSha = await createCommit({ tree: treeSha, message: key }); | ||
| if (!commitSha) { | ||
| return; | ||
| } | ||
| logger.debug(`Git commit created: ${commitSha}`); |
There was a problem hiding this comment.
Was this something you learned from previously, that it must be a commit to be retained by github?
| parents?: LongCommitSha[]; | ||
| } | ||
|
|
||
| async function createCommit({ |
There was a problem hiding this comment.
Is this an "orphan" commit we push?
There was a problem hiding this comment.
Yes, I'm not sure it's okay or not
There was a problem hiding this comment.
I wonder if it's better to create an orphan commit, with no parent, or to make it branch off the very first commit of the repo ever
Changes
Context
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via: