-
Notifications
You must be signed in to change notification settings - Fork 1.5k
feat: add unisat, bitget and binance web3 wallet bitcoin connector #4465
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
@danielsimao is attempting to deploy a commit to the Reown Team on Vercel. A member of the Team first needs to authorize it. |
b4e4cf3
to
36b4858
Compare
Deployment failed with the following error:
|
36b4858
to
20def01
Compare
Hey @enesozturk. Thank you so much for taking the time to helps us ship this. I apologize not not including the docs on the PR description Unisat Docs: https://docs.unisat.io/dev/open-api-documentation/unisat-wallet |
Thanks @danielsimao - lastly can you add unit tests for the new connector? We keen to merge this to ship on the next release. I'll follow up for the CI after we add tests |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Added. Let me know if I missed any test case @enesozturk |
@enesozturk note that images are missing for these wallets. Also, testing binance web3 would require a preview deployment because I was not able to access/test it locally. |
@danielsimao I've approved the previews so you can see on top. Here is for lab: https://appkit-laboratory-max1etm4j-reown-com.vercel.app/ |
@danielsimao Testing wallets in the Bitcoin example: https://appkit-laboratory-max1etm4j-reown-com.vercel.app/library/bitcoin/ I've realized that these wallets are not listed as separate options. There is one "UniSat Wallet" option and it's connecting to what ever it picks (UniSat wallet or BitGet) The wallets should be listed separately. Anyways tested wallets by enabling only one of them each time:
|
This is how I added the wallets.
Binance one you can access only through Binance App. They have a wallet inside it, which has a browser. Just like metamask now allows a browser in-app. I just tried and already noticed that it fails to switch chain (maybe it does not support it) |
Description
Added a new
UnisatConnector
class to support Bitcoin wallet connectivity for Unisat, Bitget, and BinanceW3W wallets (all of these use the same wallet API).NOTE: BinanceW3W injects window value inside binance web3 app browser.
Type of change
Associated Issues
For Linear issues: Closes APKT-123 (replace with actual issue ID)
For GH issues: closes #456 (replace with actual issue number)
Showcase (Optional)
N/A - No UI changes. This is a backend connector implementation.
Demo recording: [Link to demo recording, if available]
Checklist