-
Notifications
You must be signed in to change notification settings - Fork 1.5k
feat: add chainId
to w3mFrameProvider
request method
#4471
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 63aea98 The changes in this PR will be included in the next version bump. This PR includes changesets to release 23 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
10 Skipped Deployments
|
chainId
to w3mFrameProvider
request method
tomiir
approved these changes
Jun 19, 2025
enesozturk
reviewed
Jun 19, 2025
enesozturk
approved these changes
Jun 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently the secure site doesn't know from which
chainId
therpcRequest
is co. It uses the last switched network. In multi-chain environments where multiple connections are possible, there is no possiblity to sign a message onevm
libraries when connected onsolana
and otherwise. This PR updates the schema and adds achainId
to the request.Changes
w3mFrameProvider to get
getCaipNetworkby
chainNamespace`wallet
schema`authProvider
to always havechainNamespace
in requestThis PR needs a secure site change to fully function correctly.
Secure Site PR: https://github.com/reown-com/secure-appkit/pull/445
Type of change
Associated Issues
For Linear issues: Closes APKT-xxx
For GH issues: closes #...
Showcase (Optional)
If there is a UI change include the screenshots with before and after state.
If new feature is being introduced, include the link to demo recording.
Checklist