Skip to content

chore: add bitcoin wallet impl for reown extension, add e2e tests #4525

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

enesozturk
Copy link
Contributor

@enesozturk enesozturk commented Jun 18, 2025

Description

Implements BitcoinProvider for Reown browser extension to use Bitcoin extension wallet in our E2E testing suite.

This requires some update on Bitcoin adapter's WalletStandardConnector so switchNetwork implementation can be overridden with custom connector implementation.

Type of change

  • Chore (non-breaking change that addresses non-functional tasks, maintenance, or code quality improvements)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Associated Issues

For Linear issues: Closes APKT-xxx
For GH issues: closes #...

Showcase (Optional)

If there is a UI change include the screenshots with before and after state.
If new feature is being introduced, include the link to demo recording.

Checklist

  • Code in this PR is covered by automated tests (Unit tests, E2E tests)
  • My changes generate no new warnings
  • I have reviewed my own code
  • I have filled out all required sections
  • I have tested my changes on the preview link
  • Approver of this PR confirms that the changes are tested on the preview link

Copy link

linear bot commented Jun 18, 2025

Copy link

changeset-bot bot commented Jun 18, 2025

🦋 Changeset detected

Latest commit: ba8dddc

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 23 packages
Name Type
@reown/appkit-adapter-bitcoin Patch
@reown/appkit-adapter-ethers Patch
@reown/appkit-adapter-ethers5 Patch
@reown/appkit-adapter-solana Patch
@reown/appkit-adapter-wagmi Patch
@reown/appkit Patch
@reown/appkit-utils Patch
@reown/appkit-cdn Patch
@reown/appkit-cli Patch
@reown/appkit-codemod Patch
@reown/appkit-common Patch
@reown/appkit-controllers Patch
@reown/appkit-core Patch
@reown/appkit-experimental Patch
@reown/appkit-pay Patch
@reown/appkit-polyfills Patch
@reown/appkit-scaffold-ui Patch
@reown/appkit-siwe Patch
@reown/appkit-siwx Patch
@reown/appkit-testing Patch
@reown/appkit-ui Patch
@reown/appkit-wallet Patch
@reown/appkit-wallet-button Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Jun 18, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
appkit-basic-html ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 20, 2025 9:25am
appkit-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 20, 2025 9:25am
appkit-laboratory ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 20, 2025 9:25am
10 Skipped Deployments
Name Status Preview Comments Updated (UTC)
appkit-basic-example ⬜️ Ignored (Inspect) Jun 20, 2025 9:25am
appkit-basic-sign-client-example ⬜️ Ignored (Inspect) Jun 20, 2025 9:25am
appkit-basic-up-example ⬜️ Ignored (Inspect) Visit Preview Jun 20, 2025 9:25am
appkit-ethers5-bera ⬜️ Ignored (Inspect) Jun 20, 2025 9:25am
appkit-nansen-demo ⬜️ Ignored (Inspect) Jun 20, 2025 9:25am
appkit-vue-solana ⬜️ Ignored (Inspect) Jun 20, 2025 9:25am
appkit-wagmi-cdn-example ⬜️ Ignored (Inspect) Jun 20, 2025 9:25am
ethereum-provider-wagmi-example ⬜️ Ignored (Inspect) Jun 20, 2025 9:25am
next-wagmi-solana-bitcoin-example ⬜️ Ignored (Inspect) Jun 20, 2025 9:25am
vue-wagmi-example ⬜️ Ignored (Inspect) Jun 20, 2025 9:25am

Copy link

socket-security bot commented Jun 18, 2025

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License

View full report

Copy link
Contributor

github-actions bot commented Jun 18, 2025

Fails
🚫 Loose dependency versions in apps/browser-extension/package.json, please use strict versioning
Warnings
⚠️

🔑 Potential High‑entropy string detected in apps/browser-extension/src/core/BitcoinProvider.ts (line 28): 000000000019d6689c08...

⚠️

🔑 Potential High‑entropy string detected in apps/browser-extension/src/core/BitcoinProvider.ts (line 29): 000000000933ea01ad0e...

⚠️

🔑 Potential High‑entropy string detected in apps/browser-extension/src/core/BitcoinProvider.ts (line 28): 000000000019d6689c08...

⚠️

🔑 Potential High‑entropy string detected in apps/browser-extension/src/core/BitcoinProvider.ts (line 28): 000000000019d6689c08...

⚠️

🔑 Potential High‑entropy string detected in apps/browser-extension/src/core/BitcoinProvider.ts (line 28): 000000000019d6689c08...

⚠️

🔑 Potential High‑entropy string detected in apps/browser-extension/src/core/BitcoinProvider.ts (line 28): 000000000019d6689c08...

⚠️

🔑 Potential High‑entropy string detected in apps/browser-extension/src/core/BitcoinProvider.ts (line 29): 000000000933ea01ad0e...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 3): Users/enesozturk/Des...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 4): Users/enesozturk/Des...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 4): Users/enesozturk/Des...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 4): Users/enesozturk/Des...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 4): Users/enesozturk/Des...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 4): Users/enesozturk/Des...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 4): Users/enesozturk/Des...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 4): Users/enesozturk/Des...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 4): Users/enesozturk/Des...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 4): Users/enesozturk/Des...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 4): Users/enesozturk/Des...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 4): Users/enesozturk/Des...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 4): Users/enesozturk/Des...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 4): Users/enesozturk/Des...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 4): Users/enesozturk/Des...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 4): Users/enesozturk/Des...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 4): Users/enesozturk/Des...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 4): Users/enesozturk/Des...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 4): Users/enesozturk/Des...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 4): Users/enesozturk/Des...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 4): Users/enesozturk/Des...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 4): Users/enesozturk/Des...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 4): Users/enesozturk/Des...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 4): Users/enesozturk/Des...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 4): Users/enesozturk/Des...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 4): Users/enesozturk/Des...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 4): Users/enesozturk/Des...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 4): Users/enesozturk/Des...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 4): Users/enesozturk/Des...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 4): Users/enesozturk/Des...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 4): Users/enesozturk/Des...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 4): Users/enesozturk/Des...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 4): Users/enesozturk/Des...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 4): Users/enesozturk/Des...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 4): Users/enesozturk/Des...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 4): Users/enesozturk/Des...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 4): Users/enesozturk/Des...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 4): Users/enesozturk/Des...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 4): Users/enesozturk/Des...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 4): Users/enesozturk/Des...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 4): Users/enesozturk/Des...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 4): Users/enesozturk/Des...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 3): Users/enesozturk/Des...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 4): Users/enesozturk/Des...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 4): Users/enesozturk/Des...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 4): Users/enesozturk/Des...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 4): Users/enesozturk/Des...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 4): Users/enesozturk/Des...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 4): Users/enesozturk/Des...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 4): Users/enesozturk/Des...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 4): Users/enesozturk/Des...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 4): Users/enesozturk/Des...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 4): Users/enesozturk/Des...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 4): Users/enesozturk/Des...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 4): Users/enesozturk/Des...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 4): Users/enesozturk/Des...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 4): Users/enesozturk/Des...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 4): Users/enesozturk/Des...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 4): Users/enesozturk/Des...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 4): Users/enesozturk/Des...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 4): Users/enesozturk/Des...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 4): Users/enesozturk/Des...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 4): Users/enesozturk/Des...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 4): Users/enesozturk/Des...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 4): Users/enesozturk/Des...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 4): Users/enesozturk/Des...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 4): Users/enesozturk/Des...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 4): Users/enesozturk/Des...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 4): Users/enesozturk/Des...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 4): Users/enesozturk/Des...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 4): Users/enesozturk/Des...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 4): Users/enesozturk/Des...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 4): Users/enesozturk/Des...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 4): Users/enesozturk/Des...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 4): Users/enesozturk/Des...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 4): Users/enesozturk/Des...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 4): Users/enesozturk/Des...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 4): Users/enesozturk/Des...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 4): Users/enesozturk/Des...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 4): Users/enesozturk/Des...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 4): Users/enesozturk/Des...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 4): Users/enesozturk/Des...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 4): Users/enesozturk/Des...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 4): Users/enesozturk/Des...

⚠️ Testing spec changed

Generated by 🚫 dangerJS against ba8dddc

Copy link
Contributor

github-actions bot commented Jun 18, 2025

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 77.65% 30473 / 39240
🔵 Statements 77.65% 30473 / 39240
🔵 Functions 68.5% 2514 / 3670
🔵 Branches 84.33% 6299 / 7469
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
packages/adapters/bitcoin/src/connectors/WalletStandardConnector.ts 93.9% 100% 88.23% 93.9% 45-46, 214-226
Generated in workflow #12816 for commit ba8dddc by the Vitest Coverage Report Action

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant