Toshok's typescript port #30
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Domiii
commented
Aug 8, 2024
code-monkey-ts2/agents/agent.ts
Outdated
| import { BaseAgent } from "./base_agent"; | ||
|
|
||
| export abstract class Agent extends BaseAgent { | ||
| model: ReturnType<typeof createReactAgent>; |
There was a problem hiding this comment.
We always use 2 space-indent for everything where possible.
(I'm not sure why I was not able to get VSCode to use 2 space-indent for python, hence we ended up with 4 spaces there)
…om event data while reading the stream
…reuse until we have better separation of conversation history (or maybe disable the checkpointer altogether?)
…nd Coder on gpt4-o-mini). individual agent MSNs can be overridden with _MSN env vars
…the dead startup time is being spent
…it (getAllSrcFiles) was exposed, optimized it. 3.5s -> 79ms for indexFiles
… recursive function to a worklist for walking directories
Domiii
commented
Aug 9, 2024
|
|
||
| const schema = z.object({ | ||
| agent_name: z.string().describe("Name of the agent to invoke"), | ||
| prompt: z.string().describe("Prompt to run with the agent"), | ||
| }); | ||
|
|
||
|
|
||
| // a hack to clear the async local storage langchain uses to send events to the correct stream. |
There was a problem hiding this comment.
Nit: Let's move this to a separate file?
Also, generally, any code that executes on import is likely coming back to haunt you at some point in time. Putting it in an init function and requiring an explicit goal might be a better idea.
* Fix passing of `CodeContext` among agents and tools. * Add `boxen`. * Fix `indexFiles` to only do its job once. * Fix `gitignore` handling in subdirectories in `getAllSrcFiles`. * Add `runAgentPrompt`
switch to a dynamic import so we can maybe register some instrumentation plugins before importing the code we want to instrument save the service name as well, clean up some snake_case, and add the msn fields to all agent spans a lot more instrumentation fixes
|
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/[email protected] |
…round into toshok/typescript-port
Domiii
commented
Aug 14, 2024
code-monkey-ts2/instrumentation.ts
Outdated
| export function instrument<T extends (...args: any) => any>( | ||
| type ValueOfPromise<T> = T extends Promise<infer U> ? U : never; | ||
|
|
||
| function isPromise<T>(value: unknown): value is Promise<ValueOfPromise<T>> { |
There was a problem hiding this comment.
Usually, people use isThenable instead of isPromise.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.