Skip to content

Commit 059b5d1

Browse files
authored
fix(collector): limit run pod collector to delete only one related secret (#1668)
* fix(collector): limit run pod collector to delete only related secret * change to ctx
1 parent b33d553 commit 059b5d1

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

pkg/collect/run_pod.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -63,9 +63,9 @@ func (c *CollectRunPod) Collect(progressChan chan<- interface{}) (result Collect
6363

6464
if c.Collector.ImagePullSecret != nil && c.Collector.ImagePullSecret.Data != nil {
6565
defer func() {
66-
for _, k := range pod.Spec.ImagePullSecrets {
67-
if err := client.CoreV1().Secrets(pod.Namespace).Delete(context.Background(), k.Name, metav1.DeleteOptions{}); err != nil {
68-
klog.Errorf("Failed to delete secret %s: %v", k.Name, err)
66+
if c.Collector.ImagePullSecret.Name != "" {
67+
if err := client.CoreV1().Secrets(pod.Namespace).Delete(ctx, c.Collector.ImagePullSecret.Name, metav1.DeleteOptions{}); err != nil {
68+
klog.Errorf("Failed to delete secret %s: %v", c.Collector.ImagePullSecret.Name, err)
6969
}
7070
}
7171
}()

0 commit comments

Comments
 (0)