Skip to content

fix(collector): limit run pod collector to delete only one related secret #1668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 30, 2024
Merged

fix(collector): limit run pod collector to delete only one related secret #1668

merged 2 commits into from
Oct 30, 2024

Conversation

DexterYan
Copy link
Contributor

@DexterYan DexterYan commented Oct 30, 2024 •
edited
Loading

Description, Motivation and Context

  • stop using range which will delete other image pull secret

Checklist

  • New and existing tests pass locally with introduced changes.
  • Tests for the changes have been added (for bug fixes / features)
  • The commit message(s) are informative and highlight any breaking changes
  • Any documentation required has been added/updated. For changes to https://troubleshoot.sh/ create a PR here

Does this PR introduce a breaking change?

  • Yes
  • No

@DexterYan DexterYan requested a review from a team as a code owner October 30, 2024 04:01
@DexterYan DexterYan added type::bug Something isn't working bug::normal labels Oct 30, 2024
nvanthao
nvanthao requested changes Oct 30, 2024
View reviewed changes
Copy link
Member

@nvanthao nvanthao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM only 1 nit

@DexterYan DexterYan requested a review from nvanthao October 30, 2024 06:12
@banjoh banjoh merged commit 059b5d1 into main Oct 30, 2024
27 checks passed
@banjoh banjoh deleted the dx/fix-run-pod-secret branch October 30, 2024 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@banjoh banjoh banjoh approved these changes

@nvanthao nvanthao nvanthao approved these changes

Assignees
No one assigned
Labels
bug::normal type::bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DexterYan @banjoh @nvanthao