Skip to content

fix: [sc-118962] Unable to Retrieve TLS Parameters from Kubernetes Secrets with the Postgres Collector #1724

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 28, 2025

Conversation

nvanthao
Copy link
Member

@nvanthao nvanthao commented Jan 22, 2025

Story details: https://app.shortcut.com/replicated/story/118962

Changing from reading secret from StringData to Data field.

From K8S API doc

        // stringData allows specifying non-binary secret data in string form.
	// It is provided as a write-only input field for convenience.
	// All keys and values are merged into the data field on write, overwriting any existing values.
	// The stringData field is never output when reading from the API.
	// +k8s:conversion-gen=false
	// +optional
	StringData map[[string](https://pkg.go.dev/builtin#string)][string](https://pkg.go.dev/builtin#string) `json:"stringData,omitempty" protobuf:"bytes,4,rep,name=stringData"`

@nvanthao nvanthao added type::bug Something isn't working bug::normal labels Jan 22, 2025
@nvanthao nvanthao requested a review from a team as a code owner January 22, 2025 00:00
Copy link
Member

@diamonwiggins diamonwiggins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a comment.

Copy link
Member

@diamonwiggins diamonwiggins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@nvanthao nvanthao merged commit fa5365c into main Jan 28, 2025
24 checks passed
@nvanthao nvanthao deleted the gerard/sc-118962/tls-secret branch January 28, 2025 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug::normal type::bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants