Skip to content

Enable Daemonsets in ClusterResources analyzer #1729

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 6, 2025
Merged

Enable Daemonsets in ClusterResources analyzer #1729

merged 1 commit into from
Feb 6, 2025

Conversation

hedge-sparrow
Copy link
Member

Description, Motivation and Context

Enables selecting DaemonSets in the ClusterResources analyzer.

Checklist

  • New and existing tests pass locally with introduced changes.
  • Tests for the changes have been added (for bug fixes / features)
  • The commit message(s) are informative and highlight any breaking changes
  • Any documentation required has been added/updated. For changes to https://troubleshoot.sh/ create a PR here

Does this PR introduce a breaking change?

  • Yes
  • No

@hedge-sparrow hedge-sparrow requested a review from a team as a code owner February 5, 2025 15:09
banjoh
banjoh approved these changes Feb 5, 2025
View reviewed changes
Copy link
Member

@banjoh banjoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

An update https://troubleshoot.sh/docs/analyze/cluster-resource/ would be good as well

@xavpaice xavpaice added the type::feature New feature or request label Feb 5, 2025
diamonwiggins
diamonwiggins approved these changes Feb 6, 2025
View reviewed changes
Copy link
Member

@diamonwiggins diamonwiggins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@diamonwiggins diamonwiggins merged commit de791e9 into main Feb 6, 2025
24 checks passed
@diamonwiggins diamonwiggins deleted the ash/enable-ds-cra branch February 6, 2025 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@banjoh banjoh banjoh approved these changes

@diamonwiggins diamonwiggins diamonwiggins approved these changes

Assignees
No one assigned
Labels
type::feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hedge-sparrow @banjoh @diamonwiggins @xavpaice