-
Notifications
You must be signed in to change notification settings - Fork 101
Updating the cosign library for Github Actions #1752
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@@ -233,10 +233,10 @@ jobs: | |||
with: | |||
go-version: "1.23" | |||
|
|||
- uses: sigstore/cosign-installer@v3 | |||
- uses: sigstore/[email protected] | |||
with: | |||
# DO NOT USE v2 until we decide on whether to use Rekor or not |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it looks like this comment is no longer relevant. Are we choosing to use Rekor now? @St0rmz1 ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What was the concern about it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure. I can track this comment back to @banjoh 944da45#diff-3d24298139377d0eb98efea65804db3916b0ec40761eb89bf0a25de8c3fb9a87R290
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok. There is a privacy concern for private repos as the log can divulge info, but I think we are ok. But also would love to hear from @banjoh
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The concern was on cosign sending information to Rekor's transparency log. From above comment, it looks like this is OK.
with: | ||
# DO NOT USE v2 until we decide on whether to use Rekor or not | ||
cosign-release: "v1.13.1" # Binary version to install | ||
cosign-release: "v2.4.3" # Binary version to install |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we remove this now and use the latest but continue to pin the action version?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would prefer to have this version pinned because it makes the builds predictable and stable (e.g. we are safe from a bad cosign-release version that got pushed). Why do you want to use latest?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You have a valid point, but I'm also concerned that there is nothing automated to update this or notify this of updates. I would argue that the implications of this falling out of date can also introduce instability as they have here. Additionally, security is a concern.
6430b0e
to
83b0dbb
Compare
From a test run here
Looks successful! |
Fixing the following issue:
SBOM generation and signing is broken Error [sc-77445]