Skip to content

fix(collect.runPod): does not delete image pull secrets without name in spec #1761

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 17, 2025
Merged

fix(collect.runPod): does not delete image pull secrets without name in spec #1761

merged 3 commits into from
Mar 17, 2025

Conversation

emosbaugh
Copy link
Member

@emosbaugh emosbaugh commented Mar 17, 2025 •
edited
Loading

Description, Motivation and Context

If the image pull secret in the spec does not have a name and instead uses generate name it will not get deleted. This pertains to all secrets injected by kots.

Checklist

  • New and existing tests pass locally with introduced changes.
  • Tests for the changes have been added (for bug fixes / features)
  • The commit message(s) are informative and highlight any breaking changes
  • Any documentation required has been added/updated. For changes to https://troubleshoot.sh/ create a PR here

Does this PR introduce a breaking change?

  • Yes
  • No

@emosbaugh emosbaugh added type::bug Something isn't working bug::normal labels Mar 17, 2025
@emosbaugh emosbaugh changed the title fix(collect.runPod): fix deleting image pull secrets fix(collect.runPod): does not delete image pull secrets without name in spec Mar 17, 2025
@emosbaugh emosbaugh marked this pull request as ready for review March 17, 2025 21:06
@emosbaugh emosbaugh requested a review from a team as a code owner March 17, 2025 21:06
@emosbaugh emosbaugh requested review from laverya and DexterYan March 17, 2025 21:18
@emosbaugh emosbaugh merged commit 641c195 into main Mar 17, 2025
37 of 41 checks passed
@emosbaugh emosbaugh deleted the emosbaugh/20250317/run-pod-delete-image-pull-secrets branch March 17, 2025 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laverya laverya laverya approved these changes

@DexterYan DexterYan DexterYan approved these changes

Assignees
No one assigned
Labels
bug::normal type::bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@emosbaugh @laverya @DexterYan