feat: add timestamps flag to logs collector #1776
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
lamdor
changed the title
Kubernetes logs can be transmitted with the captured timestamps. This is useful for containers that do not log with timestamps. So I'm exposing that as a flag.
lamdor
force-pushed
the
la/push-kwyknquwvkuo
branch
from
0210c83 to
d24b7f2
Compare
|
I did write up a test, but I'm not entirely sure how to make sure it's testing it. |
|
I have tested this feature in a live cluster and it worked as expected. |
sgalsaleh
previously approved these changes
Apr 17, 2025
|
Thanks for the contribution! |
auto-merge was automatically disabled
April 17, 2025 14:11
Head branch was pushed to by a user without write access
|
@sgalsaleh Please re-review, I had to generate schemas. I wasn't aware I needed to do that. |
laverya
approved these changes
Apr 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description, Motivation and Context
Kubernetes logs can be transmitted with the captured timestamps. This is useful for containers that do not log with timestamps. So I'm exposing that as a flag.
Checklist
Does this PR introduce a breaking change?