Skip to content

remove macos-12 runner label #465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

@shogo82148 shogo82148 marked this pull request as draft October 21, 2024 09:18
@rhysd
Copy link
Owner

rhysd commented Oct 21, 2024

Thanks. I believe we should merge this after 2024 12/3 and after the issue has been closed.

Copy link
Owner

@rhysd rhysd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This review comment is to block the merge until the runner is completely dropped.

@AlexSkrypnyk
Copy link

Also, macos-15 is available, but reported as false positive by actionlint.

@rhysd
Copy link
Owner

rhysd commented Dec 17, 2024

macos-15 was supported at 1.7.3. If actionlint still complains about it, it should be a bug.

https://github.com/rhysd/actionlint/releases/tag/v1.7.3

EDIT: I checked the following minimal workflow with actionlint 1.7.4 and I didn't see any error. I guess your actionlint command is old.

on: push

jobs:
  example-job:
    runs-on: macos-15
    steps:
      - run: echo hello

@rhysd rhysd closed this in 6b43bb8 Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants